Skip to content

chore: revert highlight mentions while typing (WPB-1895)#3727

Merged
ohassine merged 6 commits intodevelopfrom
revert-mention-highlight
Dec 30, 2024
Merged

chore: revert highlight mentions while typing (WPB-1895)#3727
ohassine merged 6 commits intodevelopfrom
revert-mention-highlight

Conversation

@ohassine
Copy link
Copy Markdown
Member

@ohassine ohassine commented Dec 11, 2024 •
edited by github-actions Bot
Loading

StoryWPB-1895 [Android] Highlight mentions in TextInputs when typing

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

After implementing the mention highlight feature using a different BasicTextField, we realized that this approach does not support rich content due to API limitation.

As a result, we have decided to prioritize GIF support instead and will be removing the mention feature.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq Bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Dec 11, 2024
@ohassine ohassine changed the title chore: revert highlight mentions while typing chore: revert highlight mentions while typing (WPB-1895) Dec 11, 2024
@echoes-hq echoes-hq Bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Dec 11, 2024
@yamilmedina
Copy link
Copy Markdown
Contributor

yamilmedina commented Dec 11, 2024

@ohassine we need this also on release/candidate please 🙏

@pull-request-size
Copy link
Copy Markdown

pull-request-size Bot commented Dec 11, 2024

Ups 🫰🟨

This PR is too big. Please try to break it up into smaller PRs.

@ohassine ohassine requested review from a team, MohamadJaara, alexandreferris, m-zagorski, mathias-niboulies and vitorhugods and removed request for a team December 11, 2024 14:28
@ohassine ohassine changed the base branch from develop to release/candidate December 11, 2024 14:28
@ohassine ohassine changed the base branch from release/candidate to develop December 11, 2024 14:28
@ohassine ohassine mentioned this pull request Dec 11, 2024
Closed
8 tasks
@ohassine
Merge remote-tracking branch 'origin/develop' into revert-mention-hig…
249c1d9 
…hlight

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/home/messagecomposer/state/MessageComposerStateHolder.kt
@ohassine ohassine enabled auto-merge December 30, 2024 16:13
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ohassine ohassine added this pull request to the merge queue Dec 30, 2024
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.23256% with 30 lines in your changes missing coverage. Please review.

Project coverage is 45.91%. Comparing base (8bf8c7f) to head (249c1d9).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
.../messagecomposer/state/MessageCompositionHolder.kt 23.68% 29 Missing ⚠️
...mposer/state/MessageCompositionInputStateHolder.kt 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #3727      +/-   ##
===========================================
- Coverage    45.94%   45.91%   -0.03%     
===========================================
  Files          482      482              
  Lines        16441    16438       -3     
  Branches      2770     2769       -1     
===========================================
- Hits          7553     7547       -6     
- Misses        8112     8115       +3     
  Partials       776      776
Files with missing lines Coverage Δ
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...essagecomposer/state/MessageComposerStateHolder.kt 66.66% <ø> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 63.41% <80.00%> (ø)
.../messagecomposer/state/MessageCompositionHolder.kt 28.23% <23.68%> (-0.09%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bf8c7f...249c1d9. Read the comment docs.

Merged via the queue into develop with commit 118f45b Dec 30, 2024
@ohassine ohassine deleted the revert-mention-highlight branch December 30, 2024 16:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 30, 2024

Built wire-android-staging-compat-pr-3727.apk is available for download

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 30, 2024

Built wire-android-dev-debug-pr-3727.apk is available for download

@mastaab mastaab removed the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MohamadJaara MohamadJaara MohamadJaara approved these changes

@m-zagorski m-zagorski Awaiting requested review from m-zagorski m-zagorski was automatically assigned from wireapp/android

@alexandreferris alexandreferris Awaiting requested review from alexandreferris alexandreferris was automatically assigned from wireapp/android

@mathias-niboulies mathias-niboulies Awaiting requested review from mathias-niboulies mathias-niboulies was automatically assigned from wireapp/android

+1 more reviewer

@vitorhugods vitorhugods vitorhugods approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ohassine ohassine

Labels

echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ohassine @yamilmedina @codecov-commenter @MohamadJaara @vitorhugods @mastaab